dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1966386578
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java:
##########
@@ -43,20 +45,17 @@ static class InputOptions {
FileInputOptions fileOptions;
static class StandardInputOptions {
-
@CommandLine.Option(
- names = {"-r", "--realm"},
- paramLabel = "<realm>",
- required = true,
- description = "The name of a realm to bootstrap.")
- List<String> realms;
+ names = {"-c", "--credentials"},
+ description =
+ "Principal credentials to bootstrap. If provided, must be a
valid JSON array e.g. "
+ + "[{\"realm\": \"my-realm\", \"principal\": \"root\",
\"clientId\": \"polaris\", \"clientSecret\": \"p4ssw0rd\"}]")
+ String credentials;
@CommandLine.Option(
- names = {"-c", "--credential"},
- paramLabel = "<realm,clientId,clientSecret>",
Review Comment:
I believe the existing `-c` option is adequate for bootstrapping current
Polaris Server and it is convenient for users.
I think we should keep it, but I'm open to altering its format as long as it
is human-writable in shells without too much quoting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
