dimas-b commented on code in PR #955: URL: https://github.com/apache/polaris/pull/955#discussion_r1966015572
########## api/management-model/src/test/java/org/apache/polaris/core/admin/model/CatalogSerializationTest.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.admin.model; + +import static org.assertj.core.api.Assertions.assertThat; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.util.stream.Stream; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +public class CatalogSerializationTest { + + private ObjectMapper mapper; + private static final String TEST_LOCATION = "s3://test/"; + private static final String TEST_CATALOG_NAME = "test-catalog"; + private static final String TEST_ROLE_ARN = "arn:aws:iam::123456789012:role/test-role"; + + @BeforeEach + public void setUp() { + mapper = new ObjectMapper(); + } + + /** + * Helper method to verify round-trip serialization/deserialization of Catalog objects. Ensures + * all fields are preserved correctly through the process. + * + * @param original The catalog object to test + * @return The deserialized catalog for additional assertions if needed + */ + private Catalog verifyRoundTrip(Catalog original) throws JsonProcessingException { + String json = mapper.writeValueAsString(original); + Catalog deserialized = mapper.readValue(json, Catalog.class); + assertThat(deserialized).usingRecursiveComparison().isEqualTo(original); Review Comment: Why not simply assertThat(deserialized).isEqualTo(original)? Do you think the `.equals()` method in `Catalog` does not take nested objects into account? ########## .vscode/settings.json: ########## @@ -0,0 +1,13 @@ +{ + "java.configuration.updateBuildConfiguration": "automatic", + "java.compile.nullAnalysis.mode": "automatic", + "java.project.sourcePaths": [ Review Comment: ping: Please remove this file from the PR ########## .gitignore: ########## @@ -91,4 +91,4 @@ logs/ hs_err_pid* # macOS -*.DS_Store +*.DS_Store Review Comment: ping: please remove this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
