dimas-b commented on code in PR #955:
URL: https://github.com/apache/polaris/pull/955#discussion_r1952817760
##########
build.gradle.kts:
##########
@@ -126,6 +126,20 @@ tasks.named<RatTask>("rat").configure {
excludes.add("**/kotlin-compiler*")
excludes.add("**/build-logic/.kotlin/**")
+
+ excludes.add("docs/**") // Added this line to bypass adding header in docs
file
+
+ excludes.addAll(
Review Comment:
Would you mind removing this change from this PR?
##########
api/management-model/src/test/java/org/apache/polaris/core/admin/model/CatalogSerializationTest.java:
##########
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.core.admin.model;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.util.stream.Stream;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+
+/**
+ * Test suite for Catalog JSON serialization and deserialization.
+ *
+ * <p>Coverage includes:
+ *
+ * <ul>
+ * <li>Basic serialization/deserialization of Catalog objects
+ * <li>Handling of null and empty fields
+ * <li>Special character handling in field values
+ * <li>Unicode character support
+ * <li>Whitespace preservation
+ * <li>AWS role ARN validation
+ * </ul>
+ *
+ * Error handling coverage:
+ *
+ * <ul>
+ * <li>Invalid JSON input
+ * <li>Malformed JSON structure
+ * <li>Invalid enum values
+ * <li>Edge cases like very long catalog names
+ * </ul>
+ */
+public class CatalogSerializationTest {
+
+ private ObjectMapper mapper;
+ private static final String TEST_LOCATION = "s3://test/";
+ private static final String TEST_CATALOG_NAME = "test-catalog";
+ private static final String TEST_ROLE_ARN =
"arn:aws:iam::123456789012:role/test-role";
+
+ @BeforeEach
+ public void setUp() {
+ mapper = new ObjectMapper();
+ mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+ }
+
+ /**
+ * Helper method to verify round-trip serialization/deserialization of
Catalog objects. Ensures
+ * all fields are preserved correctly through the process.
+ *
+ * @param original The catalog object to test
+ * @return The deserialized catalog for additional assertions if needed
+ */
+ private Catalog verifyRoundTrip(Catalog original) throws
JsonProcessingException {
+ // Perform serialization and deserialization
+ String json = mapper.writeValueAsString(original);
+ Catalog deserialized = mapper.readValue(json, Catalog.class);
+
+ // Compare the content instead of direct object equality
+ assertThat(deserialized.getType()).isEqualTo(original.getType());
Review Comment:
Why is it necessary to assert individual field values? Why not do an equals
check on the whole object?
##########
api/management-model/build.gradle.kts:
##########
@@ -54,12 +57,26 @@ openApiGenerate {
serverVariables = mapOf("basePath" to "api/v1")
}
-listOf("sourcesJar", "compileJava").forEach { task ->
- tasks.named(task) { dependsOn("openApiGenerate") }
Review Comment:
Would you mind reverting this change? I do not see why moving these lines in
the same file is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
