dennishuo commented on code in PR #1057:
URL: https://github.com/apache/polaris/pull/1057#discussion_r1968303916
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -51,7 +51,7 @@ public interface FileIOFactory {
* @return a configured FileIO instance.
*/
FileIO loadFileIO(
- @Nonnull RealmContext realmContext,
Review Comment:
Right, I think in general we'll need to better formalize a concept of a
"SystemCallContext", and 99% of the code should still be able to operate on a
CallContext passed in through method parameters, etc., without caring where the
CallContext came from.
The initial construction would either come from request handlers and their
injected dependencies, or explicit construction from some "system-privileged"
type of thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
