dennishuo commented on code in PR #1057:
URL: https://github.com/apache/polaris/pull/1057#discussion_r1968318837
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -51,7 +51,7 @@ public interface FileIOFactory {
* @return a configured FileIO instance.
*/
FileIO loadFileIO(
- @Nonnull RealmContext realmContext,
+ @Nonnull CallContext callContext,
Review Comment:
That's a good point to keep in mind though that right now `CallContext` does
inadvertently give a big bag of goodies to the methods being called, so we
should still be careful to think about whether a smaller subset can be carved
out to minimize surface area to what is actually used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
