dennishuo commented on code in PR #1070:
URL: https://github.com/apache/polaris/pull/1070#discussion_r1972836177
##########
service/common/src/main/java/org/apache/polaris/service/context/DefaultCallContextResolver.java:
##########
@@ -60,6 +60,10 @@ public CallContext resolveCallContext(
.addKeyValue("headers", headers)
.log("Resolving CallContext");
+ // TODO: Once we have non-transactional-database persistence stores, this
should be
+ // pushed down for the metaStoreManagerFactory to inject Transactional-DB
specific things
+ // (including the MetaStoreSession" into the PolarisCallContext. The
non-transactional
Review Comment:
The MetaStoreSessionFactory kind of implies at least baking in the
`realmContext` during the construction of the handle into the persistence
store. So in general one might decorate the handle into the persistence store
with various elements of traceability/auditability, blast-radius reduction
(e.g. if it could connect to the backend with some kind of scoped internal
credentials), which is why the current architecture treats the handle into the
persistence backend as being a property of the call context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
