flyrain commented on code in PR #1070: URL: https://github.com/apache/polaris/pull/1070#discussion_r1972887604
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/BaseMetaStoreManager.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence; + +import jakarta.annotation.Nonnull; +import java.util.Map; +import org.apache.polaris.core.PolarisCallContext; +import org.apache.polaris.core.entity.PolarisBaseEntity; +import org.apache.polaris.core.entity.PolarisEntityConstants; +import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo; + +public abstract class BaseMetaStoreManager implements PolarisMetaStoreManager { + public static PolarisStorageConfigurationInfo extractStorageConfiguration( Review Comment: Is it necessary to introduce a new abstract class to just hold a static method? We could use a util class to hold it instead. ########## polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManagerImpl.java: ########## @@ -63,68 +62,12 @@ * and retrieve all Polaris metadata */ @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE") -public class PolarisMetaStoreManagerImpl implements PolarisMetaStoreManager { +public class PolarisMetaStoreManagerImpl extends BaseMetaStoreManager { Review Comment: This one should also be in the package `transactional`, as it depends on the `TransactionalPersistence` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
