collado-mike commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1974117216
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,11 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ public static final PolarisConfiguration<Integer>
STORAGE_CONFIGURATION_MAX_LOCATIONS =
+ PolarisConfiguration.<Integer>builder()
+ .key("STORAGE_CONFIGURATION_MAX_LOCATIONS")
+ .description("How many locations can be associated with a storage
configuration")
+ .defaultValue(20)
Review Comment:
My proposal is to relax the limit now and we can consider removing it at the
catalog level later. Making the limits configurable gives us knobs to control
while maintaining the existing behavior so we can more carefully test and
observe and then make decisions. I propose three controls because it means we
can exactly mimic the current behavior while still allowing for relaxed
constraints. Small, incremental changes are better than big ones, IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
