collado-mike commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1975818034
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,11 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ public static final PolarisConfiguration<Integer>
STORAGE_CONFIGURATION_MAX_LOCATIONS =
+ PolarisConfiguration.<Integer>builder()
+ .key("STORAGE_CONFIGURATION_MAX_LOCATIONS")
+ .description("How many locations can be associated with a storage
configuration")
+ .defaultValue(20)
Review Comment:
> A small concern is that it's relative easy to introduce a config, it's
much harder to remove one.
That's true, but it's only a concern if people are using it - that would
imply that people care. If the config is used to effectively remove the limit,
then removing the config is easy because removing the config effectively
enforces the configuration users already have. If people are using it because
they want a limit, then we shouldn't remove the config, but we should continue
to allow people to set the limits they want. If the config is never used
because people don't really care about the limit, then removing the config and
the limit later on is easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
