dennishuo commented on code in PR #1070: URL: https://github.com/apache/polaris/pull/1070#discussion_r1974948713
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/BaseMetaStoreManager.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence; + +import jakarta.annotation.Nonnull; +import java.util.Map; +import org.apache.polaris.core.PolarisCallContext; +import org.apache.polaris.core.entity.PolarisBaseEntity; +import org.apache.polaris.core.entity.PolarisEntityConstants; +import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo; + +public abstract class BaseMetaStoreManager implements PolarisMetaStoreManager { + public static PolarisStorageConfigurationInfo extractStorageConfiguration( Review Comment: Sorry, my fault for not clarifying this - my initial split was to immediately create the pair of abstract class at both layers: - PolarisMetaStoreManagerImpl -> BaseMetaStoreManager - PolarisMetaStoreSession -> BasePersistence And move all non-transactional shared code into the base classes in both layers. So I started this class to be the eventual landing place for code that could be shared from PolarisMetaStoreManagerImpl. Unfortunately, it turned out that first I had to do deeper surgery pushing things from PolarisMetaStoreMangaerImpl down into PolarisMetaStoreSession (now renamed TransactionalPersistence) before having any chance of extracting shared code into `BaseMetaStoreManager`. So I do still think eventually we'll have all the shared code in here in `BaseMetaStoreManager`, I just realized that it might be worth checkpointing this initial cut with the lower-level APIs defined well, so for now this class ended up mostly empty. I could revert this part for now and delete this class putting the static method back into PolarisMetaStoreManagerImpl, or I guess I could leave a TODO indicating the intention to fast-follow pushing the shared code into here. Any preference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
