dennishuo commented on code in PR #1070: URL: https://github.com/apache/polaris/pull/1070#discussion_r1974989254
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalPersistence.java: ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.transactional; + +import jakarta.annotation.Nonnull; +import jakarta.annotation.Nullable; +import java.util.List; +import java.util.function.Supplier; +import org.apache.polaris.core.PolarisCallContext; +import org.apache.polaris.core.entity.EntityNameLookupRecord; +import org.apache.polaris.core.entity.PolarisBaseEntity; +import org.apache.polaris.core.entity.PolarisEntitiesActiveKey; +import org.apache.polaris.core.entity.PolarisEntityCore; +import org.apache.polaris.core.persistence.BasePersistence; +import org.apache.polaris.core.persistence.IntegrationPersistence; + +/** + * Extends BasePersistence to express a more "transaction-oriented" control flow for backing stores Review Comment: Yeah it's a good point. Right now before all the refactoring I guess the upper layer (PolarisMetaStoreManagerImpl) is the ultimate authority on the unit of durability, and a custom impl of the traditional `PolarisMetaStoreSession` might "enforce" this by having `ensureInWriteTransaction` barriers, for example (OpenCatalog does this in its custom metastore session impl). After this refactoring, I think it should be possible to unify under the semantic of "each method call is independently durable/committed", with the addition of the new atomicBatchConditionalWrite method (or whatever we call it). As it stands in this PR, after pushing down the `entitiesActive` and `entitiesChangeTracking` stuff, the vast majority of the functionality no longer truly depends on the external layer defining the durability unit as a transaction, so we just need to chip away a few more things. The main exceptions are called out in https://docs.google.com/document/d/1U9rprj8w8-Q0SnQvRMvoVlbX996z-89eOkVwWTQaZG0/edit?tab=t.0#heading=h.2cx2yoanf9c4 - GrantRecords - we can sacrifice perfect "atomicity" in favor of slightly weaker but still good enough "happens-before" semantics, and just document the implications - Types that create external "integrations" and other peripheral entities (Catalogs, Principals, Drop -> Tasks) - also sacrifice atomicity in favor of multi-phase commit types of behaviors and/or happens-before guarantees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
