liamzwbao commented on code in PR #1126: URL: https://github.com/apache/polaris/pull/1126#discussion_r1982630833
########## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ########## @@ -215,6 +215,10 @@ public void initialize(String name, Map<String, String> properties) { name, this.catalogName); + // Ensure catalogProperties is assigned before calling metricsReporter() for proper + // functionality. + catalogProperties = properties; Review Comment: This fixes [testCatalogWithCustomMetricsReporter](https://github.com/apache/iceberg/blob/58b283e3533afce8b9884ac847a46eb40688353b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L2936) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org