liamzwbao commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2003441853


##########
regtests/setup.sh:
##########
@@ -31,7 +31,7 @@ if [ -z "${SPARK_HOME}" ]; then
 fi
 SPARK_CONF="${SPARK_HOME}/conf/spark-defaults.conf"
 DERBY_HOME="/tmp/derby"
-ICEBERG_VERSION="1.7.1"
+ICEBERG_VERSION="1.8.1"

Review Comment:
   Yes, the version here doesn’t need to match the project version exactly, but 
I think it’s better to upgrade them together for consistency.
   
   I found this by a global search for Iceberg version 1.7 within the project. 
Adding a comment in `libs.versions.toml` makes sense. However, since the 
version may sometimes be upgraded by the Renovate bot, I’m not sure if the bot 
will update the version in regtests at the same time.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to