flyrain commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r1985403860
########## service/common/src/main/java/org/apache/polaris/service/events/PolarisEventListener.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.events; + +/** + * Represents an event listener that can respond to notable moments during Polaris's execution. + * Users can either extend this interface and implement handlers for all events or, for ease, extend + * DefaultPolarisEventListener and only have to handle a subset of events. Event details are + * documented under the event objects themselves. + */ +public interface PolarisEventListener { Review Comment: Yeah, the binary compatible issue will still be there if we allow listeners to implement the current interface. There are multiple ways to solve that: 1. Adding default methods as @adutra mentioned. 2. Making `PolarisEventListener` package-private interface, so that it cannot be used out of the package. This is close to what Spark Listener does. `SparkListener` is an abstract class, implement a Scala private interface `SparkListenerInterface` 3. Enforcing the type at the event listener register time. I didn't see any event register functionality though, are we going to support multiple listeners? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
