andrew4699 commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1985524822


##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/BasePolarisCatalogTest.java:
##########
@@ -1658,4 +1670,35 @@ public void 
testRegisterTableWithSlashlessMetadataLocation() {
         .isInstanceOf(IllegalArgumentException.class)
         .hasMessageContaining("Invalid metadata file location");
   }
+
+  @Test
+  public void testEventsAreEmitted() {
+    BasePolarisCatalog catalog = catalog();
+    catalog.createNamespace(TestData.NAMESPACE);
+    Table table = catalog.buildTable(TestData.TABLE, TestData.SCHEMA).create();
+
+    String key = "foo";
+    String valOld = "bar1";
+    String valNew = "bar2";
+    table.updateProperties().set(key, valOld).commit();
+    table.updateProperties().set(key, valNew).commit();
+
+    BeforeTableRefreshEvent beforeRefreshEvent =
+        testPolarisEventListener.getLatest(BeforeTableRefreshEvent.class);

Review Comment:
   I'm very pro-var but didn't see much use of it across the project. Looks 
like it's picking up so I'll go ahead now :P



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to