eric-maynard commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r1988063980
########## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogPrefixParser.java: ########## @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.polaris.service.catalog; +package org.apache.polaris.service.catalog.iceberg; Review Comment: That's a good point. Currently, the proposal is to defer to PolarisIcebergCatalog for logical entities like namespace, and to the management APIs for entities like principal and catalog. So moving this here feels consistent with that change. However, in the future if we duplicate these APIs across and into PolarisGenericCatalog then I think it would make sense to move the prefix parser as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
