lefebsy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1989423703
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -250,6 +268,21 @@ public Builder setStorageConfigurationInfo(
awsConfig.validateArn(awsConfigModel.getRoleArn());
config = awsConfig;
break;
+
+ case S3_COMPATIBLE:
+ S3CompatibleStorageConfigInfo s3ConfigModel =
+ (S3CompatibleStorageConfigInfo) storageConfigModel;
+ config =
+ new S3CompatibleStorageConfigurationInfo(
Review Comment:
This implementation explicitly pass the s3 endpoint to the stsClient.
Apart from AWS which exposes AssumeRole, STS and globally IAM on a separate
endpoint from the S3 APIs, other S3 providers seem to use the same endpoint.
In a mixed AWS + other approach, it would be necessary to explicitly specify
the STS endpoint and the S3 endpoint.
In the non-AWS approach, it is not mandatory, it is the same endpoint
(Minio, Ceph, backblaze, Dell ECS, ...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
