dimas-b commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1987893831
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisStorageConfigurationInfo.java:
##########
@@ -62,6 +63,7 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME)
@JsonSubTypes({
@JsonSubTypes.Type(value = AwsStorageConfigurationInfo.class),
+ @JsonSubTypes.Type(value = S3CompatibleStorageConfigurationInfo.class),
Review Comment:
What is the reason to model non-AWS S3 storage as a separate config info
class as opposed to adding a few optional settings to
`AwsStorageConfigurationInfo`?
My understanding is that the same AWS SDK is used for actually access
anyway, so storage config info basically goes into the same AWS client, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
