andrew4699 commented on code in PR #1159:
URL: https://github.com/apache/polaris/pull/1159#discussion_r1989986070
##########
service/common/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java:
##########
@@ -165,12 +167,16 @@ public static Collection<String> getAccessDeniedHints() {
}
static int mapExceptionToResponseCode(RuntimeException rex) {
- Optional<Throwable> cloudException =
- Arrays.stream(ExceptionUtils.getThrowables(rex))
- .filter(IcebergExceptionMapper::isCloudException)
- .findAny();
- if (cloudException.isPresent()) {
- return mapCloudExceptionToResponseCode(cloudException.get());
+ for (Throwable t : ExceptionUtils.getThrowables(rex)) {
+ // Cloud exceptions can be wrapped by the Iceberg SDK
+ if (isCloudException(t)) {
+ return mapCloudExceptionToResponseCode(t);
+ }
+
+ // UnknownHostException isn't a RuntimeException so it's always wrapped
+ if (t instanceof UnknownHostException &&
t.getMessage().contains(AZURE_STORAGE_URL_SUFFIX)) {
+ return Status.NOT_FOUND.getStatusCode(); // Return a 404 to be
consistent with S3/GCS
+ }
Review Comment:
Currently that method is a bit specific to handling cloud exception types
like S3Exception, AzureException, etc, which this is not. It's not super
obvious to me that there's a clean way to refactor this while keeping existing
behavior, in a way that we won't have to do more refactoring the future. The
whole exception mapper just handles things in a very specific way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
