andrew4699 commented on code in PR #1159: URL: https://github.com/apache/polaris/pull/1159#discussion_r1990082600
########## service/common/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java: ########## @@ -68,6 +68,8 @@ public class IcebergExceptionMapper implements ExceptionMapper<RuntimeException> /** Signifies that we could not extract an HTTP code from a given cloud exception */ public static final int UNKNOWN_CLOUD_HTTP_CODE = -1; + @VisibleForTesting public static final String AZURE_STORAGE_URL_SUFFIX = ".blob.core.windows.net"; Review Comment: Updated to just `windows.net` for now. We can also do this iteratively if we discover more. I found this [official list](https://learn.microsoft.com/en-us/azure/security/fundamentals/azure-domains) from Microsoft which for some reason doesn't include `.dfs.windows.net` even though Google suggests that one might actually exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
