eric-maynard commented on code in PR #1170: URL: https://github.com/apache/polaris/pull/1170#discussion_r1996504734
########## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfigurationSince.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.config; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +/** + * An annotation that should be applied to all BehaviorChangeConfiguration instances. The value here + * is the Polaris version when the flag was introduced. A spotless check should validate that + * behavior change flags are not present for more than 2 minor releases or 1 major release + */ +@Target(ElementType.FIELD) +@Retention(RetentionPolicy.RUNTIME) +public @interface BehaviorChangeConfigurationSince { Review Comment: I see, I've looked through the `generator` package but I'm not sure I fully understand what it would mean for the docs to consider the annotation. I guess the idea would be to have the docs about each BehaviorChangeConfiguration describe what version the configuration was created in, etc.? In fact, I don't know if we even want to document the `BehaviorChangeConfiguration`s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
