eric-maynard commented on code in PR #1228:
URL: https://github.com/apache/polaris/pull/1228#discussion_r2006793332
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -59,8 +58,9 @@ public InMemoryPolarisMetaStoreManagerFactory(
this.storageIntegration = storageIntegration;
}
- public void onStartup(RealmContextConfiguration realmContextConfiguration) {
- bootstrapRealmsAndPrintCredentials(realmContextConfiguration.realms());
+ @Override
+ public void initializeForService(@Nonnull List<String> realmIds, @Nonnull
String defaultRealmId) {
+ bootstrapRealmsAndPrintCredentials(realmIds);
Review Comment:
It seems kinda problematic that we are peeling apart
`RealmContextConfiguration` into some of its children here. What if a
`MetaStoreManagerFactory` needs the content of some custom
`RealmContextConfiguration` to bootstrap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
