snazy commented on code in PR #1228:
URL: https://github.com/apache/polaris/pull/1228#discussion_r2008738289
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -59,8 +58,9 @@ public InMemoryPolarisMetaStoreManagerFactory(
this.storageIntegration = storageIntegration;
}
- public void onStartup(RealmContextConfiguration realmContextConfiguration) {
- bootstrapRealmsAndPrintCredentials(realmContextConfiguration.realms());
+ @Override
+ public void initializeForService(@Nonnull List<String> realmIds, @Nonnull
String defaultRealmId) {
+ bootstrapRealmsAndPrintCredentials(realmIds);
Review Comment:
... in a module that mustn't be used in polaris-quarkus-admin.
If you wanna do things with that interface somewhere, feel free to do that.
But please lets not mix Polaris-service with Polaris-admin concerns in OSS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
