eric-maynard commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r2010916897
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1374,9 +1393,9 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
tableIdentifier, oldLocation, newLocation, existingLocation);
}
if (null == existingLocation) {
- createTableLike(tableIdentifier, entity);
+ this.tableEntity = createTableLike(tableIdentifier, entity);
} else {
- updateTableLike(tableIdentifier, entity);
+ this.tableEntity = updateTableLike(tableIdentifier, entity);
Review Comment:
The risk seems very similar to the one described in [this
comment](https://github.com/apache/polaris/blob/88e75ed957773626ac4734eab7cf2f5a570c8c3f/service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java#L1375),
and that comment describes having to do a convoluted check to ensure metadata
location is consistent. Perhaps callers of `currentTableEntity` would have to
do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
