gh-yzou commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2012571749


##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1189,6 +1189,20 @@ private class BasePolarisTableOperations extends 
BaseMetastoreTableOperations {
       this.tableFileIO = defaultFileIO;
     }
 
+    protected PolarisResolvedPathWrapper getTablePath(TableIdentifier 
tableIdentifier) {

Review Comment:
   @dennishuo we previous had a discussion here 
https://github.com/apache/polaris/pull/1147#discussion_r1994650375, it seems 
people prefer to have it as EntityType instead of Subtype. Would love to hear 
what do you think here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to