eric-maynard commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2013025369
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1359,6 +1371,9 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
.setMetadataLocation(newLocation)
.build();
}
+ if (entity.getType() == PolarisEntityType.GENERIC_TABLE) {
Review Comment:
I feel like this line (now updated to subtype):
```
if (entity.getType() == PolarisEntityType.GENERIC_TABLE) {
```
Is pretty easy to interpret right? We are just checking the entity's type
(or subtype)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
