dimas-b commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2017738177
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -219,6 +214,28 @@ public void before(TestInfo testInfo) {
managementApi.createCatalog(principalRoleName, catalog);
+ restCatalog = initCatalog(currentCatalogName, ImmutableMap.of());
+ }
+
+ @AfterEach
+ public void cleanUp() {
+ client.cleanUp(adminCredentials);
+ }
+
+ @Override
+ protected RESTCatalog catalog() {
+ return restCatalog;
+ }
+
+ /**
+ * Initialize a RESTCatalog for testing.
+ *
+ * @param catalogName this parameter is currently unused.
+ * @param additionalProperties additional properties to apply on top of the
default test settings
+ * @return a configured instance of RESTCatalog
+ */
+ @Override
+ protected RESTCatalog initCatalog(String catalogName, Map<String, String>
additionalProperties) {
Optional<PolarisRestCatalogIntegrationTest.RestCatalogConfig>
restCatalogConfig =
testInfo
Review Comment:
I believe it would be preferable to avoid using `testInfo` across methods,
but instead extract the annotations in the `before()` method and share the
prepared extra config properties between methods (via a `private` field).
##########
quarkus/service/src/testFixtures/java/org/apache/polaris/service/quarkus/it/PolarisQuarkusTestBeforeClassCallback.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.quarkus.it;
+
+import io.quarkus.test.junit.callback.QuarkusTestBeforeClassCallback;
+import org.assertj.core.api.Assumptions;
+import org.assertj.core.configuration.PreferredAssumptionException;
+
+public class PolarisQuarkusTestBeforeClassCallback implements
QuarkusTestBeforeClassCallback {
+ @Override
+ public void beforeClass(Class<?> testClass) {
Review Comment:
This will be called for every class, right?
Is there a way to make one call to
`Assumptions.setPreferredAssumptionException()` is each test JVM?
Sorry, if my previous comments made you do extra work :sweat_smile: I was
only wondering what was possible.
What it actually broken without override assumption defaults?
We could put the override in a `static` block on the common / shared test
class... WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
