liamzwbao commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2017775700
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -219,6 +214,28 @@ public void before(TestInfo testInfo) {
managementApi.createCatalog(principalRoleName, catalog);
+ restCatalog = initCatalog(currentCatalogName, ImmutableMap.of());
+ }
+
+ @AfterEach
+ public void cleanUp() {
+ client.cleanUp(adminCredentials);
+ }
+
+ @Override
+ protected RESTCatalog catalog() {
+ return restCatalog;
+ }
+
+ /**
+ * Initialize a RESTCatalog for testing.
+ *
+ * @param catalogName this parameter is currently unused.
+ * @param additionalProperties additional properties to apply on top of the
default test settings
+ * @return a configured instance of RESTCatalog
+ */
+ @Override
+ protected RESTCatalog initCatalog(String catalogName, Map<String, String>
additionalProperties) {
Optional<PolarisRestCatalogIntegrationTest.RestCatalogConfig>
restCatalogConfig =
testInfo
Review Comment:
Good point! Updated the code to extract the config as a `String[]` and
removed `TestInfo` as a private field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
