flyrain commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2019491620
########## plugins/spark/README.md: ########## @@ -0,0 +1,40 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Polaris Spark Plugin + +The Polaris Spark plugin provides a SparkCatalog class, which communicates with the Polaris +REST endpoints, and provides implementations for Apache Spark's +[TableCatalog](https://github.com/apache/spark/blob/v3.5.5/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java), +[SupportsNamespaces](https://github.com/apache/spark/blob/v3.5.5/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsNamespaces.java), +[ViewCatalog](https://github.com/apache/spark/blob/v3.5.5/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ViewCatalog.java) classes. + +Right now, the plugin only provides support for Spark 3.5, Scala version 2.12 and 2.13, +and depends on iceberg-spark-runtime 1.8.1. + +# Build Plugin Jar +A task createPolarisSparkJar is added to build a jar for the Polaris Spark plugin, the jar is named as: +"polaris-iceberg-<iceberg_version>-spark-runtime-<spark_major_version>_<scala_version>.jar" + +Jars with all supported scala versions (2.12, 2.13) are built when building the Polaris project, and the +client tests also runs both version in the CI. Review Comment: ```suggestion Building the Polaris project produces client jars for both Scala 2.12 and 2.13, and CI runs the Spark client tests for both Scala versions as well. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
