gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2021422090
########## plugins/spark/v3.5/build.gradle.kts: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar + +plugins { + id("polaris-client") + alias(libs.plugins.jandex) +} + +fun getAndUseScalaVersionForProject(): String { + val sparkScala = project.name.split("-").last().split("_") + + val scalaVersion = sparkScala[1] + + // direct the build to build/<scalaVersion> to avoid potential collision problem + project.layout.buildDirectory.set(layout.buildDirectory.dir(scalaVersion).get()) + + return scalaVersion +} + +// get version information +val sparkMajorVersion = "3.5" Review Comment: The sparkVersion here is used to define the spark version used by this build file, which is used only for spark version 3.5 (since it is under spark v3.5). For example ``` implementation( "org.apache.iceberg:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersion}:${icebergVersion}" ``` The definition above defines all sparkVersions and scala versions have to be added as the gradlew projects and build targets. Another way we can do this is to parse the spark version from the project name like how I parse the scala version in function getAndUseScalaVersionForProject, which seems unnecessary since this build file is only used by spark 3.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
