eric-maynard commented on code in PR #273:
URL: https://github.com/apache/polaris/pull/273#discussion_r2023205432
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/ListEntitiesResult.java:
##########
@@ -23,45 +23,67 @@
import jakarta.annotation.Nonnull;
import jakarta.annotation.Nullable;
import java.util.List;
+import java.util.Optional;
import org.apache.polaris.core.entity.EntityNameLookupRecord;
+import org.apache.polaris.core.persistence.pagination.PageToken;
+import org.apache.polaris.core.persistence.pagination.PolarisPage;
/** the return the result for a list entities call */
public class ListEntitiesResult extends BaseResult {
// null if not success. Else the list of entities being returned
private final List<EntityNameLookupRecord> entities;
+ private final Optional<PageToken> pageTokenOpt;
+
+ /** Create a {@link ListEntitiesResult} from a {@link PolarisPage} */
+ public static ListEntitiesResult fromPolarisPage(
+ PolarisPage<EntityNameLookupRecord> polarisPage) {
+ return new ListEntitiesResult(polarisPage.data,
Optional.ofNullable(polarisPage.pageToken));
+ }
/**
* Constructor for an error
*
* @param errorCode error code, cannot be SUCCESS
* @param extraInformation extra information
*/
- public ListEntitiesResult(@Nonnull ReturnStatus errorCode, @Nullable String
extraInformation) {
+ public ListEntitiesResult(
+ @Nonnull ReturnStatus errorCode,
+ @Nullable String extraInformation,
+ @Nonnull Optional<PageToken> pageTokenOpt) {
super(errorCode, extraInformation);
this.entities = null;
+ this.pageTokenOpt = pageTokenOpt;
}
/**
* Constructor for success
*
* @param entities list of entities being returned, implies success
*/
- public ListEntitiesResult(@Nonnull List<EntityNameLookupRecord> entities) {
+ public ListEntitiesResult(
+ @Nonnull List<EntityNameLookupRecord> entities, @Nullable
Optional<PageToken> pageTokenOpt) {
Review Comment:
You're absolutely right; this is actually never null. I will fix the
annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
