eric-maynard commented on code in PR #273:
URL: https://github.com/apache/polaris/pull/273#discussion_r2023213798
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -183,4 +183,12 @@ protected FeatureConfiguration(
"How many times to retry refreshing metadata when the previous
error was retryable")
.defaultValue(2)
.buildFeatureConfiguration();
+
+ public static final PolarisConfiguration<Boolean> LIST_PAGINATION_ENABLED =
Review Comment:
As the feature is somewhat large in scope, I think it makes sense to feature
flag it off. There are regression considerations; imagine you deploy with a
metastore implementation which you later find will perform poorly when page
tokens are used. It could make sense to disable page token support for a time
being to improve performance, even if clients are providing page tokens.
Do you think this should rather be a behavior-change flag?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -183,4 +183,12 @@ protected FeatureConfiguration(
"How many times to retry refreshing metadata when the previous
error was retryable")
.defaultValue(2)
.buildFeatureConfiguration();
+
+ public static final PolarisConfiguration<Boolean> LIST_PAGINATION_ENABLED =
Review Comment:
As the feature is somewhat large in scope, I think it makes sense to feature
flag it off. There are regression considerations; imagine you deploy Polaris
with a metastore implementation which you later find will perform poorly when
page tokens are used. It could make sense to disable page token support for a
time being to improve performance, even if clients are providing page tokens.
Do you think this should rather be a behavior-change flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
