jbonofre commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2027062340
##########
build-logic/src/main/kotlin/publishing/maven-utils.kt:
##########
@@ -79,15 +79,12 @@ fun addAdditionalJarContent(project: Project): Unit =
val additionalJarContent =
tasks.register("additionalJarContent", Sync::class.java) {
// Have to manually declare the inputs of this task here on top of
the from/include below
- inputs.files(rootProject.layout.files("LICENSE", "NOTICE"))
+ inputs.files(rootProject.layout.files("licenses/LICENSE",
"licenses/NOTICE"))
Review Comment:
Yes, that's actually the behavior I'm proposing:
1. If a specific project (like `polaris-test`) contains
`src/main/resources/LICENSE` and `src/main/resources/NOTICE`, then we should
use it instead of the default one.
2. If not provided, we should "fallback" to the default ones (in
`rootProject` `licenses/LICENSE` and `licenses/NOTICE`)
You are right, I should probably test if the "project specific" `LICENSE`
and `NOTICE` files exist to avoid "overwrite/duplicate" resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
