snazy commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2027023213
##########
build-logic/src/main/kotlin/publishing/maven-utils.kt:
##########
@@ -79,15 +79,12 @@ fun addAdditionalJarContent(project: Project): Unit =
val additionalJarContent =
tasks.register("additionalJarContent", Sync::class.java) {
// Have to manually declare the inputs of this task here on top of
the from/include below
- inputs.files(rootProject.layout.files("LICENSE", "NOTICE"))
+ inputs.files(rootProject.layout.files("licenses/LICENSE",
"licenses/NOTICE"))
Review Comment:
I suspect this "clashes" with LICENSE/NOTICE present in
src/main/resources/... as well, leading to duplicate and ambiguous files.
Probably necessary to check if any of these files is present in
src/main/resources/... and omit the "defaults" here.
But also ensuring that both cases end in the same location in all target
jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
