eric-maynard commented on code in PR #1294:
URL: https://github.com/apache/polaris/pull/1294#discussion_r2027613269
##########
service/common/src/testFixtures/java/org/apache/polaris/service/catalog/PolarisPassthroughResolutionView.java:
##########
@@ -94,6 +95,14 @@ public PolarisResolvedPathWrapper getResolvedPath(
identifier);
manifest.resolveAll();
return manifest.getResolvedPath(identifier, entityType, subType);
+ } else if (key instanceof PolicyIdentifier identifier) {
+ manifest.addPath(
+ new ResolverPath(
+
PolarisCatalogHelpers.tableIdentifierToList(identifier.toTableIdentifier()),
Review Comment:
This is what I mean above about a need to rectify all these interfaces in
the future; ideally we can have some type like `EntityPath` that captures type
information as well as the hierarchy that TableIdentifier currently captures.
But I don't think that should necessarily block the PolicyCatalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
