HonahX commented on code in PR #1294:
URL: https://github.com/apache/polaris/pull/1294#discussion_r2027887560


##########
service/common/src/testFixtures/java/org/apache/polaris/service/catalog/PolarisPassthroughResolutionView.java:
##########
@@ -94,6 +95,14 @@ public PolarisResolvedPathWrapper getResolvedPath(
           identifier);
       manifest.resolveAll();
       return manifest.getResolvedPath(identifier, entityType, subType);
+    } else if (key instanceof PolicyIdentifier identifier) {
+      manifest.addPath(
+          new ResolverPath(
+              
PolarisCatalogHelpers.tableIdentifierToList(identifier.toTableIdentifier()),

Review Comment:
   Thanks for all the suggestions. I've added a helper in 
`PolarisCatalogHelpers` for this
   ```java
   public static List<String> identifierToList(Namespace namespace, String name)
   ```
   This should work for other "identifier" in the future. Another reason to do 
this is that as @flyrain mentioned, `polaris-core` cannot import classes from 
`api`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to