eric-maynard commented on code in PR #1294: URL: https://github.com/apache/polaris/pull/1294#discussion_r2027577298
########## api/polaris-catalog-service/src/main/java/org/apache/polaris/service/types/PolicyIdentifier.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.types; + +import com.google.common.base.Preconditions; +import com.google.common.base.Splitter; +import com.google.common.collect.Iterables; +import java.util.Arrays; +import java.util.Locale; +import java.util.Objects; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; + +public class PolicyIdentifier { + + private static final Splitter DOT = Splitter.on('.'); + + private final Namespace namespace; + private final String name; + + public static PolicyIdentifier of(String... names) { Review Comment: For now, can we consider using TableIdentifier? I think we should probably come up with a better abstraction than TableIdentifier and use it throughout the code base... and some APIs also just take a List<PolarisEntity> as a sort of "path". But that can wait for the future and doesn't need to block Policy work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
