singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2031572095
########## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/ConnectionManager.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.extension.persistence.relational.jdbc; + +import javax.sql.DataSource; +import org.apache.commons.dbcp2.BasicDataSource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ConnectionManager { + + private static final Logger LOGGER = LoggerFactory.getLogger(ConnectionManager.class); + + private DataSource dataSource; + + public ConnectionManager(RelationalJdbcConfiguration jdbcConfiguration) { + this.dataSource = initializeDataSource(jdbcConfiguration); + } + + private BasicDataSource initializeDataSource(RelationalJdbcConfiguration jdbcConfiguration) { + BasicDataSource bds = new BasicDataSource(); Review Comment: sounds good, i will incorporate this feedback, a some follow-up questions : I am assuming the DBOperations class which does (insert / write / transactions) gets a DS as constructor param which will injected via JdbcMetaStoreManagerFactory when its creating the `PolarisJDBCBasePersistenceImpl` ? this package will not have the config parsing logic etc. If yes how does Quarkus Admin / Server share this code of passing config or is it to minimal to be thought of ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
