singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2040376021
########## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/IdGenerator.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.extension.persistence.relational.jdbc; + +import java.util.UUID; + +public class IdGenerator { + private IdGenerator() {} + + private static volatile IdGenerator idGenerator; + + public static IdGenerator getInstance() { + if (idGenerator != null) return idGenerator; + synchronized (IdGenerator.class) { + if (idGenerator == null) { + idGenerator = new IdGenerator(); + } + } + return idGenerator; + } + + public static final long LONG_MAX_ID = 0x7fffffffffffffffL; + + public long nextId() { + // Make sure this is a positive number. + // conflicting ids don't gets accepted and is enforced by table constraints. + return UUID.randomUUID().getLeastSignificantBits() & LONG_MAX_ID; Review Comment: my understanding is the following : https://stackoverflow.com/a/39787098 can you please elaborate why would that better, I don't hold a strong opinion about this and happy to change it to SecureRandom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
