eric-maynard commented on code in PR #1378:
URL: https://github.com/apache/polaris/pull/1378#discussion_r2051401713
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1328,6 +1383,21 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
String newLocation = writeNewMetadataIfRequired(base == null, metadata);
String oldLocation = base == null ? null : base.metadataFileLocation();
+ // TODO: we should not need to do this hack, but there's no other way to
modify
+ // currentMetadata / currentMetadataLocation
+ if (updateMetadataOnCommit) {
+ try {
+ tableMetadataField.set(metadata, newLocation);
+ unsafe.putObject(metadata, changesFieldOffset, new
ArrayList<MetadataUpdate>());
Review Comment:
That's my understanding -- the alternative is to basically rewrite our own
TableOperations / CatalogHandler and then handle storage access etc. on our
own. Essentially what you commented
[here](https://github.com/apache/polaris/pull/1378#issuecomment-2816307383).
I'm supportive of doing that work, but it will be a significant refactor /
overhaul.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
