eric-maynard commented on code in PR #1179:
URL: https://github.com/apache/polaris/pull/1179#discussion_r2052747457
##########
service/common/src/main/java/org/apache/polaris/service/task/FileCleanupTaskHandler.java:
##########
@@ -103,4 +120,53 @@ public CompletableFuture<Void> tryDelete(
CompletableFuture.delayedExecutor(
FILE_DELETION_RETRY_MILLIS, TimeUnit.MILLISECONDS,
executorService));
}
+
+ /**
+ * Attempts to delete multiple files in a batch operation with retry logic.
If an error occurs, it
Review Comment:
This LGTM, but it's important to note that we may not retry in the event
that the service dies. Eventually, we should have Polaris try to drain the task
queue for any tasks that failed the first time they were run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
