adnanhemani commented on code in PR #1179:
URL: https://github.com/apache/polaris/pull/1179#discussion_r2085658294
##########
service/common/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -77,17 +77,12 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
missingFiles.size());
}
- // Schedule the deletion for each file asynchronously
- List<CompletableFuture<Void>> deleteFutures =
- validFiles.stream()
- .map(file -> super.tryDelete(tableId, authorizedFileIO, null,
file, null, 1))
- .toList();
+ CompletableFuture<Void> deleteFutures =
Review Comment:
nit: this is now a single future, so maybe we should name this
`deleteFuture` instead
##########
service/common/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -97,5 +92,25 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
}
}
- public record BatchFileCleanupTask(TableIdentifier tableId, List<String>
batchFiles) {}
+ public enum BatchFileType {
+ TABLE_METADATA("table_metadata");
Review Comment:
Not completely sure here, so am asking for context: why did we introduce
this enum type here instead of keeping it as a record? Is this going to be
extensible for something in the immediate future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
