rahil-c commented on code in PR #1439: URL: https://github.com/apache/polaris/pull/1439#discussion_r2059193161
########## service/common/src/main/java/org/apache/polaris/service/catalog/conversion/xtable/TableFormat.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.catalog.conversion.xtable; + +import com.google.common.base.Preconditions; +import java.util.Locale; + +public enum TableFormat { Review Comment: This enum I introduced to check if a format is even supported within XTable, and doing the validation on the client side, rather than sending the request to the xtable conversion service and having it fail and then send a response back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
