rahil-c commented on code in PR #1439:
URL: https://github.com/apache/polaris/pull/1439#discussion_r2059215488
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -209,6 +209,20 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean> ENABLE_XTABLE_REST_SERVICE
=
+ PolarisConfiguration.<Boolean>builder()
+ .key("ENABLE_XTABLE_REST_SERVICE")
+ .description(
+ "If true, delegates table metadata conversion to an external
XTable REST Service")
Review Comment:
> Why would the Polaris catalog service have a feature flag that controls
whether or not the XTable service is "enabled" (running)?
>
> We _do_ need feature flags to control a few behaviors:
>
> 1. Convert-on-write
> 2. Convert-on-read
I think the naming might be off i think what you wrote for
TABLE_CONVERSION_TYPE=XTable makes sense to me.
Can you help me understand in Polaris what is the distinction between
application properties vs a feature configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
