dimas-b commented on code in PR #1496:
URL: https://github.com/apache/polaris/pull/1496#discussion_r2067652715
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -93,11 +93,7 @@ public void writeEntity(
boolean nameOrParentChanged,
PolarisBaseEntity originalEntity) {
try {
- datasourceOperations.runWithinTransaction(
- statement -> {
- persistEntity(callCtx, entity, originalEntity, statement);
- return true;
- });
+ persistEntity(callCtx, entity, originalEntity, datasourceOperations);
Review Comment:
I do not mind using more optimal code paths for single statement updates.
However, I do not think this will fix the transaction serializability
problems mentioned as the main driving force behind this PR.
If you reformulated the description of this PR to state that we're improving
JDBC response times, I'd be ok with this change (minus the if/else/instanceof
code).
On the other hand, if we're trying to fix serializability errors with this
PR, I do not think it is the right fix.
Sorry if this look pedantic, but I think it is important to be precise in
out rationale for changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
