singhpk234 commented on code in PR #1496:
URL: https://github.com/apache/polaris/pull/1496#discussion_r2069284834
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -143,12 +138,12 @@ private void persistEntity(
@Nonnull PolarisCallContext callCtx,
@Nonnull PolarisBaseEntity entity,
PolarisBaseEntity originalEntity,
- Statement statement)
+ CheckedFunction<String, Integer> fn)
Review Comment:
Are you suggesting making this always String, Integer ? or rename fn to
updateFunction, I didn't made the name explicit updateFunction as we do both
insert and update :P all DMLs. is kind of done statement.exceuteUpdate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
