dimas-b commented on code in PR #1482:
URL: https://github.com/apache/polaris/pull/1482#discussion_r2069315432


##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -315,6 +315,12 @@ private PolarisBaseEntity getPolarisBaseEntity(String 
query) {
         return results.getFirst();
       }
     } catch (SQLException e) {
+      // This look-up is used for checking if the realm is bootstrap or not.
+      // If we have 1 DB per realm it might happen that the realm is not 
boostrap
+      // at all.

Review Comment:
   this logic is too obscure IMHO. Would it be preferable to have a dedicated 
`isRealmBootstrapped(realmId)` method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to