adutra commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2069488866
########## quarkus/admin/src/main/resources/application.properties: ########## @@ -49,3 +49,21 @@ quarkus.index-dependency.guava.group-id=com.google.guava quarkus.index-dependency.guava.artifact-id=guava quarkus.index-dependency.protobuf.group-id=com.google.protobuf quarkus.index-dependency.protobuf.artifact-id=protobuf-java + +#quarkus.datasource.db-kind=pgsql +#quarkus.datasource.jdbc.url=polaris +#quarkus.datasource.username=polaris +#quarkus.datasource.password=polaris +quarkus.datasource.\"realm1_ds\".db-kind=pgsql Review Comment: The problem here is that for a Datasource to be created by Quarkus, there has to be at least one build-time property defined for that datasource: `db-kind`. And you cannot pass build-time properties through `QuarkusTestResourceLifecycleManager#start`. So `PostgresRelationalJdbcLifeCycleManagement` is trying to create datasources dynamically, but since this is happening at runtime, this is not working. Thus for tests you _have_ to declare the datasources you intend to use here, along with their db-kind: ```properties quarkus.datasource.\"realm1_ds\".db-kind=pgsql quarkus.datasource.\"realm2_ds\".db-kind=pgsql quarkus.datasource.\"realm3_ds\".db-kind=pgsql # etc ``` Other runtime properties, like `jdbc.url`, `username` and `password` can (and should) be defined in `PostgresRelationalJdbcLifeCycleManagement`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
