danielhumanmod commented on code in PR #1508:
URL: https://github.com/apache/polaris/pull/1508#discussion_r2072321993
##########
service/common/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java:
##########
@@ -243,12 +243,13 @@ private Stream<TaskEntity> getMetadataTaskStream(
private List<List<String>> getMetadataFileBatches(TableMetadata
tableMetadata, int batchSize) {
List<List<String>> result = new ArrayList<>();
List<String> metadataFiles =
Review Comment:
> Is it really accurate to call puffin files metadata files, and is it
necessarily correct to group all of these together? I guess the intent here is
to collect all of the not-data files?
Good point — the original intention was to group files under the metadata/
directory to reduce the overhead of scheduling tasks. As more file types like
stats and partition stats were added later, nonDataFiles (or something similar)
might now better reflect what’s being collected.
Curious to hear your thoughts — would it be clearer to separate them, or is
the performance benefit of grouping still preferred?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
