danielhumanmod commented on code in PR #1508:
URL: https://github.com/apache/polaris/pull/1508#discussion_r2080943590
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/task/TaskTestUtils.java:
##########
@@ -161,4 +179,26 @@ public static StatisticsFile writeStatsFile(
puffinWriter.writtenBlobsMetadata().stream().map(GenericBlobMetadata::from).toList());
}
}
+
+ public static PartitionStatisticsFile writePartitionStatsFile(
+ long snapshotId, long snapshotSequenceNumber, String statsLocation,
FileIO fileIO)
+ throws IOException {
+
+ try (PuffinWriter puffinWriter =
Puffin.write(fileIO.newOutputFile(statsLocation)).build()) {
Review Comment:
> Yes, anything can work. Just doesn't want to leave an impression that it
is a puffin file. We can create a dummy file as .parquet extension as I shared
above. It is very minimal code.
Thanks for catching it, I have adjust the writing impl with parquet as the
file format for partition stat, follow the impl in
https://github.com/apache/iceberg/blob/main/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ProcedureUtil.java#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
